docs: clarify macOS od command collision - #5219
Conversation
|
Hey @zycaskevin, thanks for tightening up the macOS Before pool review picks this up, could you add the missing Surface area checklist and a Validation section to the PR body? The current Summary/Test plan already covers the why and user-facing context, so those are the only two template pieces still missing. Also, because this touches the install path users run directly, we'll keep it in the QA queue before merge. Nothing needed from you on that piece right now. |
lefarcen
added
size/S
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@zycaskevin I reviewed the README guidance, hosted install.sh error path, and the static installer test updates for the macOS /usr/bin/od collision. The changed copy stays consistent across the user-facing docs and shell fallback, and the focused validation passes locally: node --test apps/landing-page/tests/install-sh-static.test.ts and git diff --check. Thanks for tightening up this install-path edge case and making the recovery path clearer for desktop users.
|
Hey @zycaskevin — @mrcfps has signed off on the current head, so this is now queued for QA validation before merge. No action needed from you at the moment; we'll update here once that pass is done. |
AmyShang-alt
left a comment
AmyShang-alt
left a comment
There was a problem hiding this comment.
QA 验收记录
验收范围：
- README 中 macOS/WSL2
od命令冲突说明 - hosted
apps/landing-page/public/install.sh在 PATH 命中非 Open Designod时的错误提示 - install.sh 静态测试覆盖
已验证：
node --test apps/landing-page/tests/install-sh-static.test.ts通过，4/4 passgit diff --check通过- 手工模拟 PATH 前置非 Open Design
od，install.sh claude按预期退出 1，提示 macOS/Linux/WSL2 shadow 问题和 Settings -> MCP server fallback，且未继续执行安装参数写入
未验证：
- 未验证真实 Electron Settings 页面，因为本 PR 未改 Settings snippet 生成逻辑或桌面打包行为
风险/关注点：
- 主要风险是文案救援路径是否足够清楚；当前脚本和 README 已覆盖 issue #5120 的 macOS
od冲突场景
结论：
- 验收通过
AmyShang-alt
added
validated
|
Hey @zycaskevin — QA has now signed off on the current head, so that part is all set. One small housekeeping item is still open in the PR body: the Surface area checklist is still unfilled. Once that’s updated and the remaining CI check settles, this should be in good shape from the review side. |
🎉 📡 You just leveled up to Giotto
🙌 Your contributions are sending a clear signal across the network: you care about making Open Design better. Keep transmitting. 💛 Thanks for helping Open Design move forward. Keep building in the open. 🚀 📊 Rank #158 among 400+ contributors |
4 participants
Summary
odto the system octal-dump binary instead of Open Designinstall.shshadowed-binary test so the error guidance covers macOS and the Settings fallbackFixes #5120.
Surface area
install.sherror guidance for shadowedodbinariesinstall.shstatic test coverageValidation
node --test apps/landing-page/tests/install-sh-static.test.tsgit diff --checkapps/landing-page/public/install.shwith PATH resolving to/usr/bin/od, confirming the stderr now mentions macOS and the Settings → MCP server absolute-path snippet fallbackTest plan
node --test apps/landing-page/tests/install-sh-static.test.tsgit diff --checkNotes
I also tried
pnpm --filter @open-design/landing-page test, but this fresh clone has nonode_modulesand is running Node v22.22.3 while the repo declares Node~24, so the package-level test command fails before executing tests withERR_MODULE_NOT_FOUND: Cannot find package 'tsx'.The QA queue for the direct install path makes sense; nothing else needed from me on that piece right now.